SolrMarc and Solr 8.2

Hello,

 

I’ve just started working on a pull request to upgrade VuFind to use Solr 8.2:

 

https://github.com/vufind-org/vufind/pull/1477

 

However, when I try to run SolrMarc on this branch, it fails with:

 

Error Specified solrj class name, found, but it isnt a SolrServer or a SolrClient

 

Which appears to be coming from here:

 

https://github.com/solrmarc/solrmarc/blob/master/src/org/solrmarc/solr/SolrCoreLoader.java#L147

 

I’m guessing this means that the SolrJ interface has changed in yet another backward-incompatible way, and we need to come up with a new way to wrap the object.

 

Has anyone else encountered this?

 

I’m willing to put some time into investigating this more carefully, but I want to be sure I’m not repeating work that has already been done. Please let me know if you need me to put further effort into this!

 

thanks,
Demian

Demian,  

I haven't started any work looking at Solr 8.   It does indeed sound that they once again decided to change the SolrJ interface in a non-backwards compatible way.   In all likelihood you could use a Solr7 Solrj to talk to a Solr8 server and everything would be fine.  But that makes support and upgrading on your end more problematic.   

I've just looked briefly at the documentation for solr8 and the necessary interface don't seem noticably different, so maybe getting it to work won't be too hard.

-Bob

From: solrma...@googlegroups.com <solrma...@googlegroups.com> on behalf of Demian Katz <demia...@villanova.edu>
Sent: Tuesday, October 22, 2019 12:23 PM
To: solrma...@googlegroups.com <solrma...@googlegroups.com>
Subject: [solrmarc-tech] SolrMarc and Solr 8.2

--
You received this message because you are subscribed to the Google Groups "solrmarc-tech" group.
To unsubscribe from this group and stop receiving emails from it, send an email to solrmarc-tec...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM6PR03MB49220C4C7A916B8311DC1D13E8680%40DM6PR03MB4922.namprd03.prod.outlook.com.

-Tod

Tod,

 

I don’t think the browse handler is causing the SolrMarc error, since Solr itself starts up and responds as normal. However, you are correct that the browse handler does not compile with Solr 8. Here is my compiler output:

 

Buildfile: /opt/vufind-browse-handler/build.xml

 

clean:

   [delete] Deleting directory /opt/vufind-browse-handler/build

 

setup:

    [mkdir] Created dir: /opt/vufind-browse-handler/build

    [mkdir] Created dir: /opt/vufind-browse-handler/build/deps

    [mkdir] Created dir: /opt/vufind-browse-handler/build/bundled-deps

 

setup-solr-deps:

 

unpack-solr-war:

 

build-common:

    [mkdir] Created dir: /opt/vufind-browse-handler/build/common

    [javac] Compiling 8 source files to /opt/vufind-browse-handler/build/common

    [javac] warning: [options] bootstrap class path not set in conjunction with -source 8

    [javac] 1 warning

 

build-handler:

    [mkdir] Created dir: /opt/vufind-browse-handler/build/browse-handler

    [javac] Compiling 13 source files to /opt/vufind-browse-handler/build/browse-handler

    [javac] warning: [options] bootstrap class path not set in conjunction with -source 8

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/AuthDB.java:63: error: bad operand types for binary operator '>'

    [javac]         if (results.totalHits > 0) {

    [javac]                               ^

    [javac]   first type:  TotalHits

    [javac]   second type: int

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/AuthDB.java:80: error: bad operand types for binary operator '<'

    [javac]         for (int i = 0; i < results.totalHits; i++) {

    [javac]                           ^

    [javac]   first type:  int

    [javac]   second type: TotalHits

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:96: error: <anonymous org.vufind.solr.handler.BibDB$1> is not abstract and does not override abstract method scoreMode() in Collector

    [javac]         db.search(q, new SimpleCollector() {

    [javac]                                            ^

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:186: error: <anonymous org.vufind.solr.handler.BibDB$2> is not abstract and does not override abstract method scoreMode() in Collector

    [javac]         db.search(q, new SimpleCollector() {

    [javac]                                            ^

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BibDB.java:279: error: <anonymous org.vufind.solr.handler.BibDB$3> is not abstract and does not override abstract method scoreMode() in Collector

    [javac]         db.search(q, new SimpleCollector() {

    [javac]                                            ^

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseItem.java:157: warning: [deprecation] Integer(int) in Integer has been deprecated

    [javac]         this.setCount(new Integer(count));

    [javac]                       ^

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseRequestHandler.java:60: warning: [deprecation] toSolrParams(NamedList) in SolrParams has been deprecated

    [javac]         solrParams = SolrParams.toSolrParams(args);

    [javac]                                ^

    [javac] /opt/vufind-browse-handler/browse-handler/java/org/vufind/solr/handler/BrowseRequestHandler.java:94: warning: [deprecation] Integer(String) in Integer has been deprecated

    [javac]             return new Integer(s).intValue();

    [javac]                    ^

    [javac] 5 errors

    [javac] 4 warnings

 

BUILD FAILED

/opt/vufind-browse-handler/build.xml:84: Compile failed; see the compiler error output for details.

 

This is off-topic for the SolrMarc list, so we should take further discussion of the browse handler to a different forum… but it is definitely another issue that will have to be resolved!

 

- Demian

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/95D27A6A-941E-4586-B8A8-2B7195E48F0C%40uchicago.edu.

Thanks, Bob – do you want me to take a stab at this?

 

- Demian

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339B49EAF8A155F1242CDB080680%40DM5PR13MB1339.namprd13.prod.outlook.com.

It would be helpful for you to look at it.   I have a few other changes that I've been making to SolrMarc, some of which aren't even pushed to the repo yet, But I plan on pushing them soon, and doing a release (including Tod's pull request) after that.

-Bob

Sent: Tuesday, October 22, 2019 1:41 PM
To: solrma...@googlegroups.com <solrma...@googlegroups.com>
Subject: RE: [EXTERNAL] [solrmarc-tech] Re: SolrMarc and Solr 8.2

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM6PR03MB492280B704690768795FD923E8680%40DM6PR03MB4922.namprd03.prod.outlook.com.

Great, I’ll see what I can come up with this afternoon. I’ll either open a pull request or report back here, depending on my degree of success. 😊

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339A8F22BB4B5062EB4486580680%40DM5PR13MB1339.namprd13.prod.outlook.com.

Good news: it appears to have been a simple fix!

 

https://github.com/solrmarc/solrmarc/pull/86

 

Assuming you have no concerns and are able to merge this, please let me know when the new release is out so I can get us upgraded on the VuFind side!

 

thanks,

Demian

 

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/DM5PR13MB1339A8F22BB4B5062EB4486580680%40DM5PR13MB1339.namprd13.prod.outlook.com.

SolrMarc is only one source of data comprising our Solr catalog data, and I have plenty of other non-solrmarc issues to work on while migrating from Solr 5.4.0 to 8.2.0 (as you can imagine).

When you get to it, I do look forward to a new solrmarc_core_x.x.jar and I'll let you know how it goes.

I am interested in Solr 8.2. Would it be useful for me to show what I"m doing along with warnings and errors, etc, here? I'm not set up to easily compile from source, so at this point I'm only using solrmarc_core_3.3.jar

Is it required to have a JDK (which I don't have available currently in the environment where this runs) or can I make do with a JRE?

Michael,

 

Unfortunately, I think you’re going to need a JDK, for two reasons:

 

1. SolrMarc 3.3 does not work with Solr 8; you’re going to have to compile the current master code from source in order to get a compatible version (unless Bob is ready to mint a 3.4 release in the near future).
2. SolrMarc needs a JDK in order to support dynamic compilation, which it uses for custom indexing methods. You can probably get away with a JRE if you don’t need this capability, but it’s a pretty useful thing to have, so I’d recommend going the JDK route if at all possible.

 

Please let us know if we can be of further assistance! Information on errors and warnings is definitely useful, but the problems with the 3.3 release are already known and resolved, so I’d strongly recommend getting set up to compile from master before proceeding. I’m happy to answer any questions about that as well if you run into trouble!

 

- Demian

--

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/ee7d658e-d204-4924-b068-9de3a942342b%40googlegroups.com.

Excellent, glad to hear you got things working – let us know if you run into any problems along the way!

 

To view this discussion on the web visit https://groups.google.com/d/msgid/solrmarc-tech/CAF9-XVKYSuVfhpeEmgx9iJWrTX3sesWKHuB29mZV9LNwBKODTw%40mail.gmail.com.