oauth-credentials plugin adoption

26 views
Skip to first unread message

Adrien Lecharpentier

unread,
Nov 7, 2019, 11:20:04 AM11/7/19
to Jenkins Developers
Hello,

Evaristo and I would like to adopt the plugin oauth-credentials (https://github.com/jenkinsci/oauth-credentials-plugin).
I don't know the email for Matt Moore but I pinged him on the PR I opened on the repository-permission-updated [1].

Adrien Lecharpentier

unread,
Nov 8, 2019, 4:30:03 AM11/8/19
to Jenkins Developers, matt...@google.com, matt...@vmware.com
Matt, I got your emails from your Github account and the one used on the Git commit. Sorry if it's not the email you used in the Jenkins community.

Would you agree for Evaristo and I to help you maintain oauth-credentials plugin?
Thanks in advance.
--
Adrien Lecharpentier

Adrien Lecharpentier

unread,
Nov 8, 2019, 10:29:23 AM11/8/19
to Matt Moore, Jenkins Developers, matt...@google.com
Thank you for the heads up.

Le ven. 8 nov. 2019 à 15:47, Matt Moore <matt...@vmware.com> a écrit :

I haven’t touched this in many years now, and am not sure who the best person at Google to talk to about this is.  Sorry!



--
Adrien Lecharpentier

Jeremy Hartley

unread,
Nov 9, 2019, 2:01:25 AM11/9/19
to Jenkins Developers
The PR for the change of maintainership has been approved by Craig Barber who is a tech lead in the Google Cloud Graphite team which produces the modern Jenkins plugins for integration with Google Cloud Platform. I don't know if this helps.

Oleg Nenashev

unread,
Nov 10, 2019, 1:44:08 AM11/10/19
to Jenkins Developers
There is no company plugin ownership policy in Jenkins ATM. It is something on my radars. Am explicit approval from Matt Moore is needed to do the permission transfer. But indeed sign-off from Google is helpful here, thanks Jeremy


Once there is am explicit +1 from Matt in this thread or in the GitHub pill request, I will do the transfer

Adrien Lecharpentier

unread,
Nov 10, 2019, 4:15:04 AM11/10/19
to Jenkins Developers, matt...@vmware.com
I re-add Matt Moor here then.

Le dim. 10 nov. 2019 à 07:44, Oleg Nenashev <o.v.ne...@gmail.com> a écrit :
There is no company plugin ownership policy in Jenkins ATM. It is something on my radars. Am explicit approval from Matt Moore is needed to do the permission transfer. But indeed sign-off from Google is helpful here, thanks Jeremy


Once there is am explicit +1 from Matt in this thread or in the GitHub pill request, I will do the transfer

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/726cdbcf-c45c-4273-83ba-9f6027a63d28%40googlegroups.com.

Adrien Lecharpentier

unread,
Nov 12, 2019, 4:03:45 AM11/12/19
to Craig Barber, Jenkins Developers, Oleg Nenashev, Matt Moore, erjo...@google.com
Thank you both, let me re-add Jenkins Dev List so that @Oleg Nenashev can see the answers you provided.
-- Adrien

Le lun. 11 nov. 2019 à 18:46, Craig Barber <craig...@google.com> a écrit :
Thanks Matt. I approved on the issue, but will also add my LGTM here :)

On Mon, Nov 11, 2019 at 9:39 AM Matt Moore <matt...@vmware.com> wrote:

+Craig -list

 

I can’t mail the list without being a member, but here’s what I replied yesterday.

-M

 

 

From: Matt Moore <matt...@vmware.com>
Date: Sunday, November 10, 2019 at 7:25 AM
To: Adrien Lecharpentier <adrien.lec...@gmail.com>, Jenkins Developers <jenkin...@googlegroups.com>
Cc: "erjo...@google.com" <erjo...@google.com>
Subject: Re: oauth-credentials plugin adoption

 

I’m adding Eric Johnson whose team at Google has taken on ownership of other plugins my team developed (many) years ago.  It may also be worth adding Vic Iglesias, as I believe he was involved in a related thread about patching Google’s “source” plugin right before I left (I don’t have his email handy).  They might be helpful for the “Google” side.

 

From my perspective, I don’t mind.  I would like the owner to not be me as I haven’t touched these in like 5-6 years. 😊

-M

 

 

From: Adrien Lecharpentier <adrien.lec...@gmail.com>
Date: Sunday, November 10, 2019 at 1:14 AM
To: Jenkins Developers <jenkin...@googlegroups.com>, Matt Moore <matt...@vmware.com>
Subject: Re: oauth-credentials plugin adoption

 

I re-add Matt Moor here then.



--
Craig Barber
Software Engineer
Cloud Graphite: Platforms


--
Adrien Lecharpentier

Oleg Nenashev

unread,
Nov 12, 2019, 4:34:33 AM11/12/19
to Jenkins Developers
Thanks to everybody who is involved in this topic.
Matt;s response is enough to do the transfer from my PoV: "From my perspective, I don’t mind.  I would like the owner to not be me as I haven’t touched these in like 5-6 years.".
As far as I am concerned, Matt is a maintainer of the plugin. There is no track of ownership/permission transfer for this plugin.

Unless Eric Johnson or anyone else vote against the transfer in this thread, I will do the permission transfer at noon UTC tomorrow


On Tuesday, November 12, 2019 at 10:03:45 AM UTC+1, Adrien Lecharpentier wrote:
Thank you both, let me re-add Jenkins Dev List so that ...@Oleg Nenashev can see the answers you provided.
-- Adrien

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.



--
Craig Barber
Software Engineer
Cloud Graphite: Platforms


--
Adrien Lecharpentier

Oleg Nenashev

unread,
Nov 12, 2019, 8:10:57 AM11/12/19
to Eric Johnson, Adrien Lecharpentier, Craig Barber, Jenkins Developers, Matt Moore
Thanks! I have transferred the permissions according to the approvals

On Tue, Nov 12, 2019 at 2:06 PM Eric Johnson <erjo...@google.com> wrote:
A bit late in a reply - but thanks all!
Reply all
Reply to author
Forward
0 new messages