New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update document per JLReq TF discussions #17
Conversation
…s original images
new version (5.5) and previous version (3.2) are marked as n.0 (section 0 of new version) or p.0 (section 0 of previous version), in this memo.
numbers are count from 1st one, as n.n1 or p.n1
figures without integrated description could be copied from Japanese one (no need to translate), and marked as '(ok)' below.
|
At this point, following are finished (need to be checked)
|
index.html
Outdated
<p class="checkme">This document describes simple method of processing for Ruby | ||
in Japanese layout realized with technologies like CSS, SVG, and XML-FO, | ||
as references to rendering engine implementors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document describes simple method of processing for Ruby in Japanese layout realized with technologies like CSS, SVG, and XML-FO, as references to rendering engine implementors.
Maybe change it to something like:
This document describes a simple method of ruby composition for Japanese layout realized with technologies like CSS, SVG, and XML-FO, as basic information for implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about with updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use lowercase for "ruby", since it is lowercase in HTML, CSS, and many other places like the What is ruby? i18n article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
in Japanese layout realized with technologies like CSS, SVG, and XML-FO, | ||
as references to rendering engine implementors. | ||
Unlike | ||
<a href="https://www.w3.org/TR/jlreq/"><abbr title="Requirements for Japanese Text Layout">JLReq</abbr></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning towards leaving only one link of jlreq here (i.e., only use [[JLREQ]]
), but have no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this part is to have abbr tag for JLreq, so let me keep this as is.
index.html
Outdated
Japanese layout. | ||
Points took in consideration are described in | ||
<a href="#matters-considered-by-the-simple-placement-rules"></a>. | ||
Also layout of dual ruby composition is added in this document which is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "dual ruby" be "double-sided ruby"? (Same below.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to get comment from @kidayasuo (and else)...
dual from https://w3c.github.io/jlreq/#n104 (but this uses "dual ruby composition", so might not better to use...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel "double-sided" communicates what it is a bit better than dual (in Japanese "二重").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"double-sided-ruby" or "double-sided ruby"? (might be latter one,,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer using a compound adjective to modify a noun (i.e., double-sided ruby), instead of creating a compound noun (double-sided-ruby).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated by b965f3a
"large number of" → "a large number of". I found it in two places. (By the way how I refer the html code like @xfq does? (Kakkoi-!) In case of minor corrections which do not need discussions such as adding "a" or "the" it is easier for both if I can just make the change.) |
@kidayasuo You can click the "Files changed" tab on the pull request, find In the comment field, type your comment. Optionally, to suggest a specific change to the line or lines, press Footnotes: [1] You can also mark other files as "viewed" on the right of the header of the files and they will collapse. |
index.html
Outdated
Putting line break within ruby string is not allowed for mono-ruby. | ||
In addition, putting line break within ruby base text is not allowed | ||
for group-ruby. | ||
In contrast, interlinear notes may have large number of characters, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In contrast, interlinear notes may have large number of characters, | |
In contrast, interlinear notes may have a large number of characters, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed two parts.
index.html
Outdated
With this method, processing may go smoothly for the case with Kana | ||
characters as both preceding and following of ruby base text, | ||
but there is possible case of unbalanced display, | ||
like a combination of Kana character as preceding of ruby base text | ||
and Kanji character as following of ruby base text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this method, processing may go smoothly for the case with Kana | |
characters as both preceding and following of ruby base text, | |
but there is possible case of unbalanced display, | |
like a combination of Kana character as preceding of ruby base text | |
and Kanji character as following of ruby base text | |
With this method, it can have an unbalanced look when Kana precedes the | |
ruby base and Kanji follows, or vice versa. |
Simplified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somehow feel over-simplified on this point,,. How it is unbalanced might be difficult for those who is not familiar with Japanese?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this method, processing may go smoothly for the case with Kana | |
characters as both preceding and following of ruby base text, | |
but there is possible case of unbalanced display, | |
like a combination of Kana character as preceding of ruby base text | |
and Kanji character as following of ruby base text | |
This method works well when characters preceding and following the ruby base are both Kana | |
or both Kanji. It however can have an unbalanced look when one is Kana and the other is Kanji | |
and if the ruby text is longer than the ruby base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so as it explains that it would lay over Kana but not on Kanji. but I agree it might be over-simplified as it removes a whole sentence of the good case. How about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated by afeab5f
Co-authored-by: Yasuo Kida (木田泰夫) <33173251+kidayasuo@users.noreply.github.com>
Co-authored-by: Yasuo Kida (木田泰夫) <33173251+kidayasuo@users.noreply.github.com>
Co-authored-by: Yasuo Kida (木田泰夫) <33173251+kidayasuo@users.noreply.github.com>
591274f
to
88e2a13
Compare
pushed as 88e2a13, could you check @kidayasuo ? |
Approving the PR (did I already?). The document will be ready for FPWD once minor pending fixes are complete (Shimono-san said he will finish them by next Monday (in a timezone wherever the Monday comes last :)). The document has a room for polish but the consensus at jlreq is it will be done after the FPWD. |
Thank you for review. I'll remove all checkme and merge this shortly. |
for #16
Japanese version PDF ref. https://lists.w3.org/Archives/Public/public-i18n-japanese/2020AprJun/0155.html
Preview | Diff