Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmark examples: Update links to related documents and SkipTo script #2624

Merged
merged 8 commits into from Jun 11, 2023
Merged

Landmark examples: Update links to related documents and SkipTo script #2624

merged 8 commits into from Jun 11, 2023

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Feb 18, 2023 •
edited by michael-n-cooper-bot

Also made some minor edits to the resources page

WAI Preview Link (Last built on Sun, 11 Jun 2023 00:58:36 GMT).

@michael-n-cooper-bot michael-n-cooper-bot mentioned this pull request Feb 18, 2023
Closed
@css-meeting-bot css-meeting-bot mentioned this pull request Feb 21, 2023
Merged
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> jongund: We've been using a very old version of skipto
<jugglinmike> Matt_King: I'd like to hold off on this one for about a week. After that week, we may have to rebase or merge in the "main" branch

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> Subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> Matt_King: I think this is waiting on me
<jugglinmike> Jem: Two regression tests failed
<jugglinmike> Matt_King: Occassionally there are timing issues, and sometimes they'll pass if you just have them run again (e.g. by pushing another commit to the pull request's branch)

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> Subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> Matt_King: I haven't gotten to this yet, so we'll keep it on the list

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration.

The full IRC log of that discussion <jugglinmike> subtopic: Landmark examples: Updated SkipTo script and configuration
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> jongund: This is a simple fix
<jugglinmike> Matt_King: Kurt, I may assign this to you, but we can include it in next week's agenda
<jugglinmike> jongund: This solution works for this example. I don't know if it work in a general way

@jongund
Copy link
Contributor Author

jongund commented May 11, 2023

@mcking65
Not sure why one of the regression tests is failing for toolbar, none of the toolbar files were changed in this pull request.

@howard-e
Copy link
Contributor

@jongund I I'm assuming it's a flaky test because the related pull_request action ran successfully, but the push action did not. So I went ahead and re-ran the action (and it now passes).

For context, the error was reported as a timeout by the test runner.

Error: 
not ok 92 - toolbar_toolbar › content/patterns/toolbar/examples/toolbar.html [data-test-id="toolbar-menuitemradio-aria-checked"]: menuitemradio elements have aria-checked set
  ---
    name: AssertionError
    message: Rejected promise returned by test
    values:
      'Rejected promise returned by test. Reason:': |-
        TimeoutError {
          remoteStacktrace: '',
          message: `Waiting for menu to open␊
          Wait timed out after 10141ms`,
        }
    at: |-
      Wait timed out after 10141ms
      node_modules/selenium-webdriver/lib/webdriver.js:929:17
      runMicrotasks (<anonymous>)
  ...

@jongund
Copy link
Contributor Author

jongund commented May 11, 2023

@howard-e
Thank you for fixing the problem. I tired rerunning the tests, but it still reported the problem.

@jongund
Copy link
Contributor Author

jongund commented Jun 6, 2023

@howard-e
I made an update on this pull request, but the preview links failed to be created.
Who can look into this?

@howard-e
Copy link
Contributor

howard-e commented Jun 6, 2023 •
edited

@jongund the error described in the failed build, under the 'Update site files' step is:

Error:

/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48
throw new Error(
^

Error: Could not determine content type for file at /home/runner/work/wai-aria-practices/wai-aria-practices/_external/aria-practices/content/about/introduction/introduction.html
This file may not follow established conventions.
at determineContentType (/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48:9)

The condition for this happening seems related to w3c/wai-aria-practices#219 since that w3c/wai-aria-practices has been updated recently.

I've manually updated the generated PR, w3c/wai-aria-practices#198 and re-ran the action, so the link is now available again.

@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern labels Jun 11, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jun 11, 2023
@mcking65 mcking65 changed the title Landmark examples: Updated SkipTo script and configuration Landmark examples: Update links to related documents and SkipTo script Jun 11, 2023
@mcking65 mcking65 merged commit 4adb78e into main Jun 11, 2023
20 checks passed
Landmark Regions Guidance and Examples Development Project automation moved this from Next Steps to Complete Jun 11, 2023
@mcking65 mcking65 deleted the update/landmark-examples branch June 11, 2023 04:59
@mcking65 mcking65 added the enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy label Jun 30, 2023
@mcking65 mcking65 removed this from the H1/2023 Content Updates milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Landmark Regions Guidance and Example...
  
Complete
Milestone
2023-06-20 Publication Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jongund @css-meeting-bot @howard-e @mcking65