Infrastructure: Update script that provides skipto menu on all pages to version 5.1 #2619
Conversation
|
Please edit the opening comment and list changes since V4.2. This will both help with testing and enable us to have a descriptive commit statement in the history. |
There was a problem hiding this comment.
There are some differences in the attributions in the copyright statements. Please more consistently mirror the language used in the prior version statement. We promised to keep it consistent.
This version:
* Copyright (c) <2022, 2023> (version 5.1) Jon Gunderson, University of Illinois and PayPal
* All rights reserved.
Prior version:
/*! skipto - v4.2.0 - 2022-06-16
* https://github.com/paypal/skipto
* Copyright (c) 2022 Jon Gunderson; Licensed BSD
* Copyright (c) 2021 PayPal Accessibility Team and University of Illinois; Licensed BSD */
|
I believe it would be better if the script did not wrap the button in a navigation region. If a page author wants to put the button inside of an existing region, perhaps they can do that. I don't think the script should presume that the author wants to add another region to the page. Personally, I find regions containing a single element to be pretty annoying. On rare occasion they become necessary because there is an important element in the middle of the page that does not belong in the prior or next region -- that is an extreme edge case and often represents undesirable design. Because the button is the first element, it is trivial to get to it and almost impossible for screen reader users to overlook. The region is thus adding verbosity that does not provide utility. If we really wanted it to be inside of a region, which I don't believe is necessary as it is not actual page content, we could make it the first element in the banner. However, I believe it is better that it is outside the banner. If it were persistently visible to all users, I would advocate that it be the first element inside the banner. |
mcking65
changed the title
mcking65
changed the title
|
@mcking65 |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> subtopic: Infrastructure: Update script that provides skipto menu on all pages to version 5.1 by jongund · Pull Request #2619 · w3c/aria-practices<jugglinmike> github: https://github.com//pull/2619 <jugglinmike> Matt_King: I'll review copyright <jugglinmike> jongund: I talked to someone at Paypal, and they told me that Paypal is ending support for a number of open source projects. The repository referenced in these comments has been abandoned. <jugglinmike> Jem: I volunteer to perform a functional/visual review? <jugglinmike> Matt_King: Depending on where this ends up on Friday, it may be possible to include for Monday <jugglinmike> Matt_King: I don't think we need further legal advice on this one <Jem> https://github.com//pull/2624 |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: Infrastructure: Update script that provides skipto menu on all pages to version 5.1 by jongund · Pull Request #2619 · w3c/aria-practices<jugglinmike> github: https://github.com//pull/2619 <jugglinmike> Matt_King: I made two changes to the "skipto.js" file. They were strictly editorial--within code comments. Minor typos <jugglinmike> Jem: I will finish my review by the end of my day today |
mcking65
added
Infrastructure
navelement.divso it does not create a navigation landmark.WAI Preview Link (Last built on Tue, 28 Feb 2023 19:04:02 GMT).