Allow pcap_set_buffer_size() to set SNF_DATARING_SIZE in pcap-snf.c. #435
Conversation
|
So the ring size argument to snf_open() is in bytes? |
|
The dataring_sz argument to snf_open() is considered to be in bytes if it is greater than or equal to 1048576. If it is less than that, it is considered in megabytes. If the value is zero or less than 0, the Sniffer library tries to choose a sensible default unless the SNF_DATARING_SIZE variable is set in the environment. |
Then perhaps if the value provided by |
|
Or just pass 1048576 if the value is > 0 but < 1048576, as you'd have to round up the value after dividing it by 1048576. |
in pcap-snf.c. value is adjusted to the minimum of 1MB.
|
Thanks. I'll treat the value as in bytes and convert it to the minimum of 1048576 if it < 1MB. |
…=0x2. It now will update description info if existing device list matches a SNF interface. It will also adjust SNF interface name in description field if SNF_FLAGS=0x2(port aggregation enabled).
|
So the only part of this change that survived your most recent commit is the "Update snf_findalldevs() ..." part; did you really intend not to "Allow pcap_set_buffer_size() to set SNF_DATARING_SIZE in pcap-snf.c"? |
|
Right. I may add pcap_set_buffer_size() support back in later after some more review and discussion. Thanks for noticing. |
No description provided.