New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 480: Update PEP 480 to account for changes to PEP 458 #1681
Conversation
This commit adds various updates to account for changes in PEP 458, including: * updating the link to the Python glossary * add definitions of distribution file, target files * clarify ‘target files’ and ‘target metadata’ * Use BLAKE 2 instead of SHA-2 in filenames * transaction process -> upload process This commit also adds a few clarifications about the purpose of this PEP, including adding an overview of the changes needed to implement the PEP. Signed-off-by: marinamoore <mnm678@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for minor comments
Use the permanent links from theupdateframework.io Signed-off-by: marinamoore <mnm678@gmail.com>
to developer keys, adding a process to register developer keys with PyPI, and a | ||
change in the upload workflow for developers who take advantage of end-to-end | ||
signing. All of these changes are described in detail later in this PEP. Package | ||
managers that wish to take advantage of end-to-end signing do not need to do any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this all in one paragraph, it's easy to miss that the last sentence is about clients rather than the backend infrastructure. I'd suggest make it a separate paragraph and emphasising the *not*
While I did have a minor cosmetic comment on one of the new paragraphs, I went ahead and merged this to improved the consistency of the online version with PEP 458. |
Ah, Marina did not add her name to the PEP, I forgot to note this, next time... |
This commit adds various updates to account for changes in PEP 458, including: * updating the link to the Python glossary * add definitions of distribution file, target files * clarify ‘target files’ and ‘target metadata’ * Use BLAKE 2 instead of SHA-2 in filenames * transaction process -> upload process * update paper links to use the permanent links from theupdateframework.io This commit also adds a few clarifications about the purpose of this PEP, including adding an overview of the changes needed to implement the PEP. Signed-off-by: marinamoore <mnm678@gmail.com>
This commit adds various updates to account for changes in PEP 458, including:
This commit also adds a few clarifications about the purpose of this PEP, including adding an overview of the changes needed to implement the PEP