site: Update list of Envoy extensions required for Contour #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2265 +/- ##
==========================================
- Coverage 78.24% 77.35% -0.89%
==========================================
Files 57 58 +1
Lines 5070 5154 +84
==========================================
+ Hits 3967 3987 +20
- Misses 1017 1080 +63
- Partials 86 87 +1
Continue to review full report at Codecov.
|
davecheney
reviewed
Feb 20, 2020
site/_resources/envoy.md
Outdated
| @@ -34,13 +34,12 @@ Contour requires the following extensions. | |||
| If you are using the image recommended in our [example deployment][4] no action is required. | |||
| If you are providing your own Envoy it must be compiled with the following extensions: | |||
|
|
|||
| - `access_loggers`: `envoy.file_access_log`,`envoy.http_grpc_access_log`,`envoy.tcp_grpc_access_log` | |||
| - `filters.http`: `envoy.buffer`,`envoy.cors`,`envoy.csrf`,`envoy.ext_authz`,`envoy.fault`,`envoy.filters.http.adaptive_concurrency`,`envoy.filters.http.dynamic_forward_proxy`,`envoy.filters.http.grpc_http1_reverse_bridge`,`envoy.filters.http.grpc_stats`,`envoy.filters.http.header_to_metadata`,`envoy.filters.http.jwt_authn`,`envoy.filters.http.original_src`,`envoy.filters.http.rbac`,`envoy.filters.http.tap`,`envoy.grpc_http1_bridge`,`envoy.grpc_json_transcoder`,`envoy.grpc_web`,`envoy.gzip`,`envoy.health_check`,`envoy.ip_tagging`,`envoy.rate_limit`,`envoy.router`,`envoy.squash` | |||
| - `access_loggers`: `envoy.file`,`envoy.http_grpc`,`envoy.tcp_grpc` | |||
There was a problem hiding this comment.
I think these have been renamed to
“envoy.access_loggers.file”
“envoy.access_loggers.http_grpc”
“envoy.access_loggers.tcp_grpc”
https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/filter/accesslog/v2/accesslog.proto
There was a problem hiding this comment.
There were some others that I updated. Do we need to version this extension list?
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
updateEnvoyExtensions
branch
from
bc8ba61
to
fbb930e
Compare
|
In an ideal world, I guess we should version it, but in the world where there is only one supported version of envoy and and even tighter constraint that the current version of contour may not support it, we can probably just say this extension list applies to the current stable contour version’s envoy.
I’d like to table this until if/when we have a discussion about extending the number of supported contour versions.
On 21 Feb 2020, at 07:01, Steve Sloka <notifications@github.com> wrote:
@stevesloka commented on this pull request.
________________________________
In site/_resources/envoy.md<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprojectcontour%2Fcontour%2Fpull%2F2265%23discussion_r382227530&data=02%7C01%7Ccheneyd%40vmware.com%7Cfc339b97ba3a4c6d91c908d7b63fb7ed%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637178257089841538&sdata=j%2B5w96HbOaXxHgCRe4SeYf3zHHcVD1FNtjy8Ccprz1g%3D&reserved=0>:
@@ -34,13 +34,12 @@ Contour requires the following extensions.
If you are using the image recommended in our [example deployment][4] no action is required.
If you are providing your own Envoy it must be compiled with the following extensions:
…-- `access_loggers`: `envoy.file_access_log`,`envoy.http_grpc_access_log`,`envoy.tcp_grpc_access_log`
-- `filters.http`: `envoy.buffer`,`envoy.cors`,`envoy.csrf`,`envoy.ext_authz`,`envoy.fault`,`envoy.filters.http.adaptive_concurrency`,`envoy.filters.http.dynamic_forward_proxy`,`envoy.filters.http.grpc_http1_reverse_bridge`,`envoy.filters.http.grpc_stats`,`envoy.filters.http.header_to_metadata`,`envoy.filters.http.jwt_authn`,`envoy.filters.http.original_src`,`envoy.filters.http.rbac`,`envoy.filters.http.tap`,`envoy.grpc_http1_bridge`,`envoy.grpc_json_transcoder`,`envoy.grpc_web`,`envoy.gzip`,`envoy.health_check`,`envoy.ip_tagging`,`envoy.rate_limit`,`envoy.router`,`envoy.squash`
+- `access_loggers`: `envoy.file`,`envoy.http_grpc`,`envoy.tcp_grpc`
There were some others that I updated. Do we need to version this extension list?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fprojectcontour%2Fcontour%2Fpull%2F2265%3Femail_source%3Dnotifications%26email_token%3DAAABYA6O2Q7PQBWMU22APKTRD3OSXA5CNFSM4KYUSGV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWLKMPY%23discussion_r382227530&data=02%7C01%7Ccheneyd%40vmware.com%7Cfc339b97ba3a4c6d91c908d7b63fb7ed%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637178257089851533&sdata=IYeVTqxRspQ0Op1uY%2BbsAZfVARWC0PrJPk%2FPxN0dYcE%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAABYA2HRKSVEFBAY6D7LQDRD3OSXANCNFSM4KYUSGVQ&data=02%7C01%7Ccheneyd%40vmware.com%7Cfc339b97ba3a4c6d91c908d7b63fb7ed%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637178257089851533&sdata=DsldJK6X5rSM9u%2FRGK11Hyydhjlo6YnplLCHRpDguXA%3D&reserved=0>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2048
Image used for testing:
stevesloka/envoy-contour:v1.13.0Signed-off-by: Steve Sloka slokas@vmware.com