Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: add Contour 1.1.0 to 1.2.0 upgrade notes #2259

Merged
merged 1 commit into from Feb 21, 2020
Merged

site: add Contour 1.1.0 to 1.2.0 upgrade notes #2259

merged 1 commit into from Feb 21, 2020

Conversation

davecheney
Copy link
Contributor

Fixes #2257

Signed-off-by: Dave Cheney dave@cheney.net

@davecheney davecheney added this to the 1.2.0 milestone Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020 •
edited

Codecov Report

Merging #2259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2259   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files          58       58           
  Lines        5154     5154           
=======================================
  Hits         3987     3987           
  Misses       1080     1080           
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6000b22...dd523e9. Read the comment docs.

jpeach
jpeach reviewed Feb 20, 2020
View reviewed changes
site/_resources/upgrading.md Outdated

```
$ kubectl delete namespace projectcontour
$ kubectl apply -f examples/<your-desired-deployment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't previously notice that we recommended this. The only thing you can apply here is examples/contour, it's likely to be confusing to suggest otherwise.

I think this should advise https://projectcontour.io/quickstart/contour.yaml, like we do elsewhere.

@davecheney
Copy link
Contributor Author

davecheney commented Feb 20, 2020 via email

stevesloka
stevesloka reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the comments.

Curious about the change to the site/Gemfile.lock?

site/_resources/upgrading.md Outdated
If the following are true for you:

* Your installation is in the `projectcontour` namespace.
* You are using one of the [example][1] deployments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to @jpeach comment this should also be updated.

site/_resources/upgrading.md Outdated

Change the Contour image version to `docker.io/projectcontour/contour:v1.2.0`.

TODO(stevesloka): add information for configuring the Envoy shutdown manager.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShutdownManager has docs which explain it's configuration. The default examples and rendered examples have the manager configured in the Envoy DS. Might be able to just link to those docs and call out the change?

@davecheney
Copy link
Contributor Author

Oops the gem file commit is a mistake, I'll remove it from the commit. thanks for spotting it

@davecheney davecheney force-pushed the fixedbugs/2257 branch 5 times, most recently from a960a01 to 389341f Compare February 21, 2020 01:34
@davecheney
site: add Contour 1.1.0 to 1.2.0 upgrade notes
dd523e9 
Fixes projectcontour#2257

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney merged commit b40292b into projectcontour:master Feb 21, 2020
@davecheney davecheney deleted the fixedbugs/2257 branch February 21, 2020 01:46
@youngnick youngnick mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach left review comments

@stevesloka stevesloka stevesloka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Contour 1.2.0 release notes
3 participants
@davecheney @jpeach @stevesloka