New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS FWTS ACPI DSDT failures (Invalid ACPI CIDs) #67
Comments
the invalid _CID issue due to a check in FWTS (https://git.launchpad.net/fwts/tree/src/lib/src/fwts_acpi_object_eval.c#n1924 ) that validates the _CIDs and _HIDs to have valid format per ACPI spec. The test simply checks for either a PNP ID (3 capitals followed by 4 hex) or ACPI ID (4 capitals or digits followed by 4 hex), as defined in the ACPI spec (*). Removing these _CIDs or changing them to valid strings resolves the issue. However, these Ids are used in the windows IoT BSP drivers https://github.com/ms-iot/rpi-iotcore and removing them will break those drivers to some users: BCMGPIO |
Microsoft already defined standard-looking IDs for _HID, so we can just use those for _CID as well and deprecate the current non-standard ones. (Or just remove these _CIDs) Changes for open source drivers are easy (actually most drivers match using _HID only or as an option, except Arasan/SDHost). But the proprietary MCCI DWCHSOTG driver matches with DWC_OTG only, so that would be tricky (either convince MCCI to release a v2, or hack the INF files). Side note: For the Arasan controller, I need to somehow separate Pi3 and Pi4 in ACPI (the ACT LED is wired differently), if _HID is a good way to do this, I propose the following IDs: Pi3 Pi4 |
@driver1998, can you please confirm that copying the existing values from the _HIDs to the _CIDs (e.g. replacing CID "BCMGPIO" with the value from the HID: "BCM2845") works on RPi3 with the Windows IoT BSP drivers? |
I have a testing firmware running right now, and they work fine. |
Moved the _AEI failure to its own issue #92 |
REF: pftf/RPi4#67 Remove non-standard RPI ACPI _CIDs that are not needed. The RPi drivers at https://github.com/raspberrypi/windows-drivers should still be able to match the ACPI objects using the HIDs which are supported in the drivers. Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
REF: pftf/RPi4#67 Remove non-standard RPI ACPI _CIDs that are not needed. This fixes and FWTS failure as well. The windows drivers at https://github.com/raspberrypi/windows-drivers should still be able to match the ACPI objects using the HIDs which are supported in the drivers, with these two recent changes needed: 469702898789e555c6947e50216a3f79e0ddeb9 and 5c5e2742b4c983b3001c473b168b0dae2fcba0c2 Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Remove non-standard RPI ACPI _CIDs that are not needed. This also fixes the FWTS failure reported in pftf/RPi4#67 The windows drivers at https://github.com/raspberrypi/windows-drivers are still able to match the ACPI objects using the HIDs which are supported in the drivers, with these two recent changes needed: 469702898789e555c6947e50216a3f79e0ddeb9 and 5c5e2742b4c983b3001c473b168b0dae2fcba0c2 Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Pete Batard <pete@akeo.ie> Cc: Andrei Warkentin <awarkentin@vmware.com> Cc: Mario Bălănică <mariobalanica02@gmail.com> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Tested-by: Mario Bălănică <mariobalanica02@gmail.com>
Remove non-standard RPI ACPI _CIDs that are not needed. This also fixes the FWTS failure reported in pftf/RPi4#67 The windows drivers at https://github.com/raspberrypi/windows-drivers are still able to match the ACPI objects using the HIDs which are supported in the drivers, with these two recent changes needed: 6469702898789e555c6947e50216a3f79e0ddeb9 and 5c5e2742b4c983b3001c473b168b0dae2fcba0c2 Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Pete Batard <pete@akeo.ie> Cc: Andrei Warkentin <awarkentin@vmware.com> Cc: Mario Bălănică <mariobalanica02@gmail.com> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Tested-by: Mario Bălănică <mariobalanica02@gmail.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> Tested-by: Sunny Wang <sunny.wang@arm.com> Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
Fixed released in https://github.com/pftf/RPi4/releases/tag/v1.29 |
From the ACS tests on Rel 1.15
https://github.com/pftf/acs-reports/blob/master/v1.15/acs-enterprise-v2.4/luv-results-2020-06-12--16-30-39/parsed/fwts
The text was updated successfully, but these errors were encountered: