Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RPi specific GraphicsConsoleDxe #32

Closed
samerhaj opened this issue Apr 7, 2020 · 2 comments
Closed

Remove RPi specific GraphicsConsoleDxe #32

samerhaj opened this issue Apr 7, 2020 · 2 comments
Assignees
@samerhaj
Labels
uefi-future Everything is possible given enough time and energy

Comments

@samerhaj
Copy link
Member

samerhaj commented Apr 7, 2020

There is no need to carry our own GraphicsConsoleDxe. The version from MdeModulePkg seems to work just fine.

Some historical commits of why the override was needed back then:

andreiw/RaspberryPiPkg@2c8f675#diff-8fac8267e1fd36706978d0f7198bf681

andreiw/RaspberryPiPkg@765bfd9
@samerhaj samerhaj added the uefi-future Everything is possible given enough time and energy label Apr 7, 2020
@samerhaj samerhaj self-assigned this Apr 7, 2020
@andreiw
Copy link
Member

andreiw commented Apr 10, 2020

Yes, this can be removed.

samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 11, 2020
@samerhaj
Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
11a931e 
Switch from the PI specific GraphicsConsoleDxe driver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves pftf/RPi4#32

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pete Batard <pete@akeo.ie>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 11, 2020
@samerhaj
Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
2b6a2d1 
Switch from the PI specific GraphicsConsoleDxe driver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves pftf/RPi4#32

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pete Batard <pete@akeo.ie>

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 11, 2020
@samerhaj
Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe
58713f4 
Remove the PI specific GraphicsConsoleDxe driver, since RPi3/RPi4
switched to using the common driver in MdeModulePkg.

This resolves pftf/RPi4#32

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pete Batard <pete@akeo.ie>

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 14, 2020
@samerhaj
Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
97b1d50 
Switch from the PI specific GraphicsConsoleDxe driver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves pftf/RPi4#32

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 14, 2020
@samerhaj
Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
12e2732 
Switch from the PI specific GraphicsConsoleDxe driver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.

This resolves pftf/RPi4#32

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 14, 2020
@samerhaj
Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe
d0dcb72 
Remove the PI specific GraphicsConsoleDxe driver, since RPi3/RPi4
switched to using the common driver in MdeModulePkg.

This resolves pftf/RPi4#32

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
@pbatard
Copy link
Member

pbatard commented Apr 21, 2020

I would assert this can be closed now.

@pbatard pbatard closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samerhaj samerhaj

Labels
uefi-future Everything is possible given enough time and energy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreiw @pbatard @samerhaj