0-width bitstrings #931
Merged
0-width bitstrings #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blp
reviewed
Apr 5, 2021
p4-16/spec/P4-16-spec.mdk
Outdated
| positive integer greater than 0. When using an expression for the | ||
| size they must be parenthesized. | ||
| positive integer greater or equal to 0. When using an expression for | ||
| the size they must be parenthesized. Bitstrings with width 0 are |
There was a problem hiding this comment.
"expression" is singular, so "they" should be "it".
|
Implement this check in the compiler. |
|
I realized that |
|
The compiler supports this now in p4lang/p4c#2724 |
|
If I can get a review on this PR we can probably merge it as well. |
9 tasks
jnfoster
approved these changes
May 4, 2021
p4-16/spec/P4-16-spec.mdk
Outdated
| @@ -2038,7 +2040,7 @@ values, P4 provides a special bit-string type whose size is set at | |||
| runtime, called a `varbit`. | |||
|
|
|||
| The type `varbit<W>` denotes a bit-string with a width of at most `W` | |||
| bits, where `W` must be a positive integer that is a compile-time | |||
| bits, where `W` must be a positive or zero integer that is a compile-time | |||
There was a problem hiding this comment.
weird, I was pretty sure I had made this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personnel
Design
Implementation
p4-spec: 0-width bitstrings #931p4c: Support for 0-width bit and varbit p4c#2724Process
p4-spec:p4c: