Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation why there is no packet length field in PSA #927

Merged
merged 1 commit into from Apr 29, 2021
Merged

Add explanation why there is no packet length field in PSA #927

merged 1 commit into from Apr 29, 2021

Conversation

jafingerhut
Copy link
Contributor

No description provided.

@jafingerhut
Copy link
Contributor Author

FYI @konne88

This was referenced Mar 18, 2021
Closed
Closed
@konne88
Copy link

konne88 commented Apr 29, 2021

looks good to me

@stefanheule
Copy link

Looks good to me.

gbrebner
gbrebner approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@gbrebner gbrebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with me,

@jafingerhut
Copy link
Contributor Author

Thanks for checking this over and the positive acknowledgement. Merging in this "change".

@jafingerhut jafingerhut merged commit 99ad2bf into p4lang:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrebner gbrebner gbrebner approved these changes

@vgurevich vgurevich vgurevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jafingerhut @konne88 @stefanheule @gbrebner @vgurevich