Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match_kind optional to PSA specification #920

Merged
merged 2 commits into from Apr 20, 2021

Conversation

jafingerhut
Copy link
Contributor

No description provided.

Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@konne88
Copy link

konne88 commented Mar 18, 2021

@jafingerhut

Do we also have to update this file?
https://github.com/p4lang/p4c/blob/master/p4include/psa.p4#L400

@jafingerhut
Copy link
Contributor Author

@konne88 To support this in p4c, yes that psa.p4 include file would need to be updated, too.

@konne88
Copy link

konne88 commented Mar 18, 2021

Thanks Andy. Once we add it to the p4c include file, do you know if it would it just work, or would we also have to change the compiler?

Would we submit this PR first, and then send the followup PR to the p4c repo?

@jafingerhut
Copy link
Contributor Author

I think submitting it for the p4c compiler would be reasonable now, perhaps with a note that it is probably best to wait for this PR to be merged before merging that one.

There is only an incomplete open source p4c back end that supports the PSA architecture for behavioral-model (a process called psa_switch, instead of simple_switch) today, and it fails to support so many other PSA features that if it fails to support match_kind optional for a while longer, I don't think anyone will notice. PSA architecture implementations for other targets may very well beat that one to completion. (help welcome on the BMv2 PSA support, if you know of anyone interested)

@jafingerhut
Copy link
Contributor Author

There was discussion of this topic in the P4 LDWG meeting early April, with no objections for adding this to the PSA. There was discussion of what a prerequisite might be for adding match_kind optional to core.p4, i.e. the base language specification, but that can be more fully discussed later. Adding this to PSA now is useful and desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants