varyvol and alecharp to adopt oauth-credentials plugin #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@varyvol and I wish to adopt the plugin
varyvol
approved these changes
Nov 8, 2019
|
Waiting for @mattmoor to approve. |
|
Given Matt Moore feedback on the ml, I think we can consider it approved. He's not working in this anymore |
|
It would be helpful to have people post links to ml stuff, we shouldn't have to go searching through the ml for information to say things are good to go. |
|
for reference: https://groups.google.com/forum/?nomobile=true#!topic/jenkinsci-dev/IacUBgCCmaU/ Not sure why only my messages are appearing but we can see @mattmoor answer. |
|
LGTM from Cloud Graphite. |
craigdbarber
approved these changes
Nov 8, 2019
|
I replied in the mailing list about the current state of the ownership policy. My preference is to have explicit approval from Matt here |
|
Landing it as it was confirmed by @mattmoore in the dev list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@varyvol and I wish to adopt the plugin
Description
The OAuth Credentials plugin was not released in over 5years, even if some commits were made after the last release. @varyvol and I want to help @mattmoor to maintain this plugin.
The plugin is located here: jenkinsci/oauth-credentials-plugin
Submitter checklist for changing permissions
Always
When adding new uploaders (this includes newly created permissions files)
@mention an existing maintainer to confirm the permissions request, if applicableMerge permission to GitHub repository