Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Start mongo with enabled access control #81

Merged
merged 1 commit into from Feb 28, 2020

Conversation

difince
Copy link
Member

@difince difince commented Feb 19, 2020

Mongo DB is started firstly bound to localhost, then all users, databases and collection are initialized,
and finally mongo db is restarted with enabled access control and --bind_ip_all

Fix: #77

Note: When database credentials are not generated on every restart of the system, a follow up issue could be opened, that so that the logic inside edgex-mongo and the restart of mongo itself to happen only on the first start .

Signed-off-by: difince dianaa@vmware.com

Mongo DB is started firstly bounth to localhost, then all users, databases and collection are initialized,
and mongo db is restarted with enabled access control and --bind_ip_all

Signed-off-by: difince <dianaa@vmware.com>
@difince difince requested a review from tingyuz February 19, 2020 16:12
@difince
Copy link
Member Author

difince commented Feb 21, 2020

@bnevis-i bnevis-i added this to QA/Code Review in Security WG Feb 22, 2020
@tingyuz
Copy link
Contributor

tingyuz commented Feb 26, 2020

@difince the change of the code looks good to me. Do we need #50 of app-service-configurable to be merged first before approving & merging this one?

@tsconn23 tsconn23 merged commit 799e6f2 into edgexfoundry:master Feb 28, 2020
Security WG automation moved this from QA/Code Review to Done Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Security WG
  
Done
Development

Successfully merging this pull request may close these issues.

Start Mongo with enabled access control
3 participants