This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Allow Laravel 5.6 #435
Merged
Allow Laravel 5.6 #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this please be merged quickly |
|
For some reason the tests have not run and I would like to make sure everything passes before we release this. I could not run the tests locally because my php version needs to be updated. |
|
ah ok weird
yes is just what I have also done, been updating to 5.6 and also needed an updated php version
thanks for the reply
…________________________________
From: Dimitris Savvopoulos <notifications@github.com>
Sent: Friday, February 9, 2018 10:06 PM
To: dimsav/laravel-translatable
Cc: nousename; Comment
Subject: Re: [dimsav/laravel-translatable] Allow Laravel 5.6 (#435)
For some reason the tests have not run and I would like to make sure everything passes before we release this. I could not run the tests locally because my php version needs to be updated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdimsav%2Flaravel-translatable%2Fpull%2F435%23issuecomment-364582849&data=02%7C01%7C%7C34ededf37ea34ab3df2f08d570094e75%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636538107622372055&sdata=LgurWsiwBioXfkHU780rRSXDk4hqQVPmHJmeI%2BTgUJg%3D&reserved=0>, or mute the thread<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACaPagXC6nUZZAwpscox-bpNZ6smhcoMks5tTMFIgaJpZM4R99Hn&data=02%7C01%7C%7C34ededf37ea34ab3df2f08d570094e75%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636538107622372055&sdata=0cEn9XjA%2B2B%2BQqtjYMn2DFZW0CJBuRgAEzsUBMvlVX0%3D&reserved=0>.
|
|
@dimsav
|
|
Thanks! |
|
New version was just tagged. Thank you all for your help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.