Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mx:Alert Prevents Module From Loading in IE #826

Closed
yishayw opened this issue May 10, 2020 · 4 comments
Closed

mx:Alert Prevents Module From Loading in IE #826

yishayw opened this issue May 10, 2020 · 4 comments

Comments

@yishayw
Copy link
Contributor

yishayw commented May 10, 2020

The main app:

<?xml version="1.0" encoding="utf-8"?>
<mx:Application xmlns:mx="library://ns.apache.org/royale/mx" xmlns:fx="http://ns.adobe.com/mxml/2009"
		   applicationComplete="init()">
	<fx:Script>
		<![CDATA[
			private function init():void
			{
				ml.url = "Test1.swf";
			}
		]]>
	</fx:Script>
	<mx:VBox width="600" height="600">
		<mx:ModuleLoader id="ml"/>
	</mx:VBox>
</mx:Application>

Test1.mxml :

<?xml version="1.0" encoding="utf-8"?>
<mx:Module xmlns:mx="library://ns.apache.org/royale/mx" 
	xmlns:fx="http://ns.adobe.com/mxml/2009" width="500" height="500">
	
<fx:Script>	<![CDATA[			
	import mx.controls.Alert; // delete this line to see module in IE
]]></fx:Script>
<mx:Label text="hello from module"/>
</mx:Module>

Removing the import means module is loaded, leaving it means it hangs.

I'm running this in debug mode.

@yishayw
Copy link
Contributor Author

yishayw commented May 12, 2020

It's a mystery to me why dialogPolyfill.as is even referenced here. The only places I see dialogPolyfill referenced are in Jewel Alert and in mdl Dialog. Where is mx Alert getting this?

@aharui
Copy link
Contributor

aharui commented May 12, 2020

Good question. Sometimes there are clues in the _deps.js and other .js files. Search for polyfill and see how it gets referenced.

@aharui
Copy link
Contributor

aharui commented May 12, 2020

It was bugging me so I looked. The compiler is not being smart about grabbing inject_html from externs. It does not check whether an extern is actually used or not.

Still, though, we want to fix the pattern in case someone does use inject_html, so my suggesting to eliminate inject_html and replace with inject_js still seems like a good idea.

@yishayw
Copy link
Contributor Author

yishayw commented May 15, 2020

Fixed with 14322f1

@yishayw yishayw closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants