Remove bucketServerLocation if timeout error #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@echobravopapa @pdxcodemonkey This is the PR with the change regarding the client metadata update when there is a timeout error that I mentioned in the dev list |
|
@pdxcodemonkey @echobravopapa Have you had the opportunity to check how could I add a test to verify this? What if I create a separate ticket for the test case and this change is merge in the meanwhile? As after a timeout there is always a IO error, this change seems an improvement in the current situation when that happens, as it is in our case. |
|
I will use a separated ticket and branch for this issue, so im closing this PR. New one is here #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.