GEODE-10020: For Ping task avoid registering new destination endpoint #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanac
force-pushed
the
newfeature1/GEODE-10020
branch
from
e48432e
to
4553799
Compare
mivanac
requested review from
gesterzhou,
boglesby,
nabarunnag,
jake-at-work,
Bill,
echobravopapa,
kamilla1201 and
kirklund
as code owners
jake-at-work
changed the title
kirklund
reviewed
Jun 6, 2022
Comment on lines
296
to
300
| await().untilAsserted(() -> assertThat(getQueuedEvents(vm1, senderId)).isEqualTo(0)); | ||
|
|
||
| await().untilAsserted(() -> assertThat(getSenderPoolDisconnects(vm1, senderId)).isEqualTo(0)); | ||
|
|
||
| await().untilAsserted(() -> assertThat(getPoolEndPointSize(vm1, senderId)).isEqualTo(1)); |
There was a problem hiding this comment.
You can combine these into one await() if you want to:
await().untilAsserted(() -> {
assertThat(getQueuedEvents(vm1, senderId)).isEqualTo(0);
assertThat(getSenderPoolDisconnects(vm1, senderId)).isEqualTo(0);
assertThat(getPoolEndPointSize(vm1, senderId)).isEqualTo(1);
});
There was a problem hiding this comment.
Thanks for comments. Updated.
|
Hi |
jake-at-work
approved these changes
Jun 28, 2022
mkevo
pushed a commit
to Nordix/geode
that referenced
this pull request
Oct 27, 2022
…apache#7749) * GEODE-10020: For Ping task avoid registering new destination endpoint
mkevo
pushed a commit
to Nordix/geode
that referenced
this pull request
Nov 7, 2022
…apache#7749) * GEODE-10020: For Ping task avoid registering new destination endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[*] Has your PR been rebased against the latest commit within the target branch (typically
develop)?[*] Is your initial contribution a single, squashed commit?
[*] Does
gradlew buildrun cleanly?[*] Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?