GEODE-9484: Improve sending message to multy destinations #7664
Conversation
mivanac
requested review from
Bill,
echobravopapa,
agingade,
kamilla1201 and
jake-at-work
as code owners
mivanac
force-pushed
the
newfeature2/GEODE-9484
branch
2 times, most recently
from
d9842c6
to
477ae4e
Compare
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett |
|
This PR would probably get more notice with a properly formatted and descriptive title. |
| @@ -258,7 +309,7 @@ private Integer createServerCache() throws Exception { | |||
| server.setPort(port); | |||
| server.setNotifyBySubscription(true); | |||
| server.start(); | |||
| return server.getPort(); | |||
| return new Integer(server.getPort()); | |||
There was a problem hiding this comment.
Unnecessary explicit integer boxing.
There was a problem hiding this comment.
Thanks for comments. Updated.
mivanac
force-pushed
the
newfeature2/GEODE-9484
branch
from
477ae4e
to
d0bce73
Compare
mivanac
changed the title
* GEODE-9484: New solution to first try only one attempt to create all connections * GEODE-9484: added fix for NPE
* GEODE-9484: New solution to first try only one attempt to create all connections * GEODE-9484: added fix for NPE
Problem:
When replicating to other servers, current logic would first create connections toward all servers, and then replicate data over those connections. Creation of connections will last, until all connections are created, or destination server/s is/are declared dead.
Solution:
New proposal is, when replicating data, first try to create connections to all destinations in one attempt. For all created connections we will replicate data. After this step is completed, we will try to create remaining connections to all unreachable destinations, until connections are established, or destination is declared dead. If connections are established we will replicate data.
For more info see https://cwiki.apache.org/confluence/display/GEODE/Improve+data+inconsistency+in+replicated+regions
For all changes:
[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[*] Has your PR been rebased against the latest commit within the target branch (typically
develop)?[*] Is your initial contribution a single, squashed commit?
[*] Does
gradlew buildrun cleanly?[*] Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?