Upgrade to Gradle 7.4 #7351
Open
Upgrade to Gradle 7.4 #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to Gradle 7.4 - Updated gradle wrapper - Updated usage of an internal TemporaryFileProvider to the correct location for Gradle 7 - Update the `main` -> `mainClass` for the geode assembly to match Gradle 7 syntax - Move some `compile` scope to `compileOnly` (required for Gradle 7) - Add explicit `dependsOn` relationship between tasks that have dependencies that Gradle 7 complains about - Add a `duplicatesStrategy` to the processIntegrationTestResources to avoid Gradle 7 failing on a duplicate resources in shiro.ini (this duplicate _seems_ to come from how the source set is configured) - Upgrade the RepeatTestExecutor to match the DefaultTestExecutor from Gradle 7.4
rhoughton-pivot
added
the
windows
demery-pivotal
suggested changes
Feb 10, 2022
There was a problem hiding this comment.
In gradle-test-projects, the compileOnly dependency in the build.gradle file should be implementation. That fixes the failing acceptance test on my Mac, running with either JDK 8 or JDK 11.
The JMX test that's failing in the distributed test run is notoriously fickle. The failure is likely unrelated to this PR.
geode-assembly/src/acceptanceTest/resources/gradle-test-projects/management/build.gradle
Outdated
Show resolved
Hide resolved
…ix issue with the acceptance test build
rhoughton-pivot
suggested changes
Feb 10, 2022
demery-pivotal
approved these changes
Feb 11, 2022
rhoughton-pivot
approved these changes
Feb 15, 2022
ryangardner
requested review from
jdeppe-pivotal and
onichols-pivotal
as code owners
onichols-pivotal
requested changes
Feb 22, 2022
onichols-pivotal
approved these changes
Feb 25, 2022
|
Sorry, I've been away from my computer this week - I saw your earlier comment about updating the commit message and I can still do that, I've just not had a chance yet. |
|
Hi Ryan, I don't know if you're subscribed dev@geode.apache.org, I just posted an announcement there clarifying things. |
|
Ah, ok. I wasn't offended by the message but the announcement clarifies the
intent. Thanks.
Ryan
…On Fri, Feb 25, 2022, 7:12 PM Owen Nichols ***@***.***> wrote:
Hi Ryan, I don't know if you're subscribed ***@***.***, I just
posted an announcement
<https://lists.apache.org/thread/y3s11x39lwsmxjyw7y7oznlqolszyjn6> there
clarifying things.
—
Reply to this email directly, view it on GitHub
<#7351 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZOVLHUTGETGTIXUFR5HTU5ALHLANCNFSM5N52WGGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @ryangardner , I haven't forgotten about this. We have some internal tooling that is not ready to make the jump to Gradle 7 yet. But when it is, then this will be merged. Thanks so much for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Gradle 7.4
main->mainClassfor the geode assembly to match Gradle 7 syntaxcompilescope tocompileOnly(required for Gradle 7)dependsOnrelationship between tasks that have dependencies that Gradle 7 complains aboutduplicatesStrategyto the processIntegrationTestResources to avoid Gradle 7 failing on a duplicate resources in shiro.ini (this duplicate seems to come from how the source set is configured)For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
I couldn't find one
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?I have some errors with bind exceptions for some of the tests, but those also happen on the gradle 6.8 build for me and I haven't looked deeply into them.
Have you written or updated unit tests to verify your changes?
N/A
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?