New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage #7323
Conversation
d933fa4
to
6cc4480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't introduce any tests to cover the new behaviour, and the RFC linked to in the ticket is still in draft mode. This PR should be put into draft mode too, until discussion of the RFC is complete, then marked ready for review once the implementation matches what was finally decided on in the RFC and has sufficient test coverage.
3dd0c75
to
0b72ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment deleted
b4daf08
to
4ab1496
Compare
6e0d943
to
cdf410b
Compare
Hi @kirklund , Thanks |
Hi @kirklund , are changes OK with you? |
cdf410b
to
c3f530e
Compare
Hi @kirklund , are changes OK with you? |
Hi @kirklund , are changes OK with you? |
…duplicate events on secondary buckets
c3f530e
to
c9127e5
Compare
Hi @upthewaterspout, @agingade and @dschneider-pivotal Thanks |
Since for one month there is no feedback/review of requested changes.
@Experimental | ||
void prepareForStop(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All experimental APIs should have javadoc and annotation explanation strings. Please see MetricsPublishingService as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since changes are only for internal use, impacts moved to InternalGatewaySender interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kirklund , are changes OK with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kirklund , are changes now OK?
9d4f97f
to
1b67927
Compare
1b67927
to
3433ff0
Compare
Since API changes are removed, and modifications are not reviewed for 27 days, I will dismiss CR
* GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage to signal duplicate events on secondary buckets
* GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage to signal duplicate events on secondary buckets
Implement logic, that for each dispatcher thread, in case events are unsuccessfully dispatched, when marking them as possible duplicate, for same batch of events notify secondary bucket.
Remove current logic, to mark all events in bucket, when it becomes primary.
For more info see https://cwiki.apache.org/confluence/display/GEODE/Improve+possible+duplicate+logic+for+secondary+buckets+in+WAN
For all changes:
[*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[*] Has your PR been rebased against the latest commit within the target branch (typically
develop
)?[*] Is your initial contribution a single, squashed commit?
[*] Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?