Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt uninitialized_default_construct and uninitialized_default_construct_n to C++ 20 #5415

Merged

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jun 27, 2021

Adapted uninitialized _default_construct and uninitialized_default_construct_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

@msimberg
Copy link
Contributor

retest

@msimberg
Copy link
Contributor

launch perftests

@hkaiser
Copy link
Member

hkaiser commented Jul 1, 2021

retest lsu

hkaiser
hkaiser previously approved these changes Jul 3, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Jul 3, 2021

retest lsu

@msimberg
Copy link
Contributor

msimberg commented Jul 5, 2021

@Jedi18 this one also needs rebasing after merging #5389. If you think it'd be easier you can also rebase the C++20 algorithm PRs on top of each other so that you don't have to rebase them after merging. That does mean they should be merged in the order that they are rebased, however.

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 5, 2021

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants