Adapt lexicographical_compare to C++20 #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
|
Can one of the admins verify this patch? |
|
add to whitelist |
This was referenced May 23, 2021
…fixed sentinel tests
|
@Jedi18 The newly added test fails compiling: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/7708/workflows/3673147f-437e-43bc-9448-64f158db2bc2/jobs/251639/steps. Could you please have a look? |
|
@hkaiser Sure ok done, sorry for the delay in fixing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted lexicographical_compare to C++ 20 and added container overloads. (range and sentinel)
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668