Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreach adapt #4809

Merged
merged 10 commits into from Jul 13, 2020
Merged

Foreach adapt #4809

merged 10 commits into from Jul 13, 2020

Conversation

gonidelis
Copy link
Contributor

Adapt for_each in order to support for the begin and end iterators to be of different type

@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

@gonidelis
Copy link
Contributor Author

Should I use the is_sentinel_for trait too?

@msimberg
Copy link
Contributor

add to whitelist

@gonidelis
Copy link
Contributor Author

gonidelis commented Jul 11, 2020 •
edited

Important Note: Please don't merge yet. Need to add a couple of doxygen comments.

@hkaiser Please tell me if HPX_CONCEPT_REQUIRES_ format is fine:

  • The requirements are all aligned
  • The && operator is separated with space
  • There is extra indentation for the second line of the "two-lines requirements"
  • clang-format off includes the template parameters declaration (when it includes just the HPX_CONCEPT_REQUIRES macro, clang-format messes up the alignment of clang-format off and clang-format on comments)

hkaiser
hkaiser previously approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

@hkaiser hkaiser added this to Open Tickets in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser moved this from Open Tickets to Work in progress in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser merged commit 4016672 into STEllAR-GROUP:master Jul 13, 2020
Standard Algorithms automation moved this from Work in progress to Merged to master Jul 13, 2020
@hkaiser hkaiser added this to the 1.5.0 milestone Jul 13, 2020
@gonidelis gonidelis deleted the foreach_adapt branch July 22, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

@msimberg msimberg Awaiting requested review from msimberg

Assignees
No one assigned
Labels
category: algorithms type: enhancement
Projects
Standard Algorithms
  
Merged to master
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gonidelis @jenkins-cscs @msimberg @hkaiser