Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yang: add vrf model #5492

Closed
wants to merge 1 commit into from
Closed

yang: add vrf model #5492

wants to merge 1 commit into from

Conversation

chiragshah6
Copy link
Member

module: frr-vrf
+--rw lib
+--rw vrf* [name]
+--rw name string
+--rw id? uint32

Signed-off-by: Chirag Shah chirag@cumulusnetworks.com

module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name    string
        +--rw id?     uint32

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@polychaeta polychaeta added the yang label Dec 6, 2019
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

@LabN-CI
Copy link
Collaborator

LabN-CI commented Dec 6, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5492 b3cc4a1
Date 12/06/2019
Start 01:05:18
Finish 01:30:55
Run-Time 25:37
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-12-06-01:05:18.txt
Log autoscript-2019-12-06-01:06:11.log.bz2
Memory 433 436 360

For details, please contact louberger

@@ -0,0 +1,50 @@
module frr-vrf {
yang-version 1.1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of #5492 it is defined yang/frr-vrf.yang as it was missing. Also it seems you have raised PR against master but we are using nb_conversions branch to commit all NB changes for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new PR-5501 against nb_conversions brnach.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9977/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

<TITLE>clang_check</TITLE>

clang_check

}
description
"VRF Id.";
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an additional identifier could inform which vrf backend it is.
a leaf named ns_name optional, which is a string big enough to contain the path of the ns : eg: /var/run/netns/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added ns_name optional field to check if netns feature is enabled.

@chiragshah6
Copy link
Member Author

PR-5501 is created to develop in nb_conversion branch.

@chiragshah6 chiragshah6 closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants